-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train][release_test] Update release tests for xgboost and lightgbm trainer to V2 #49223
[Train][release_test] Update release tests for xgboost and lightgbm trainer to V2 #49223
Conversation
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just ran the release test, and if that passes, we can merge.
Release test: https://buildkite.com/ray-project/release/builds/27902 |
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
The new release test link is here: https://buildkite.com/ray-project/release/builds/28263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: the release test passed.
@justinvyu @matthewdeng Please merge :) |
Why are these changes needed?
This PR upgrades the release tests for
XGBoostTrainer
andLightGBMTrainer
from a previous version to a recent version. Both trainers are now subclass ofDataParallelTrainer
, similar toTorchTrainer
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.