Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train][release_test] Update release tests for xgboost and lightgbm trainer to V2 #49223

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

hongpeng-guo
Copy link
Contributor

@hongpeng-guo hongpeng-guo commented Dec 11, 2024

Why are these changes needed?

This PR upgrades the release tests for XGBoostTrainer and LightGBMTrainer from a previous version to a recent version. Both trainers are now subclass of DataParallelTrainer, similar to TorchTrainer

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just ran the release test, and if that passes, we can merge.

@justinvyu
Copy link
Contributor

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
@hongpeng-guo
Copy link
Contributor Author

The new release test link is here: https://buildkite.com/ray-project/release/builds/28263

@hongpeng-guo hongpeng-guo added the go add ONLY when ready to merge, run all tests label Dec 17, 2024
Copy link
Contributor Author

@hongpeng-guo hongpeng-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: the release test passed.

@hongpeng-guo
Copy link
Contributor Author

@justinvyu @matthewdeng Please merge :)

@matthewdeng matthewdeng merged commit f1b27b5 into ray-project:master Dec 17, 2024
6 checks passed
@hongpeng-guo hongpeng-guo deleted the hpguo/release_test_trees branch December 17, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants