Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add bazel includes for external libs missing them for lsp #49175

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Dec 9, 2024

Why are these changes needed?

To give clangd and other lsp's the ability to see these external headers when they're included. Other dependencies already do this.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Dec 10, 2024
@jjyao jjyao merged commit cd2cbc3 into ray-project:master Dec 17, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
…-project#49175)

Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
@dayshah dayshah deleted the add-includes branch December 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants