Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] properly encode query string #48823

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

aslonnie
Copy link
Collaborator

for tests against /test/http_get

for tests against `/test/http_get`

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie
Copy link
Collaborator Author

@jjyao says "dashboard is co-owned by core and observebility"

Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable looking change, but what's the motivation? Was a test failing?

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 20, 2024
@aslonnie
Copy link
Collaborator Author

reasonable looking change, but what's the motivation? Was a test failing?

replied offline. the test in default installation test is failing.

@aslonnie aslonnie enabled auto-merge (squash) November 20, 2024 19:54
@aslonnie aslonnie merged commit d585b8a into master Nov 20, 2024
6 checks passed
@aslonnie aslonnie deleted the lonnie-241120-testhttpget branch November 20, 2024 20:36
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
for tests against `/test/http_get`

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
for tests against `/test/http_get`

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants