Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune][Fix]Remove the clear_checkpoint function during Trial restoration error handling. #48532

Merged
merged 7 commits into from
Nov 6, 2024
Merged

[Tune][Fix]Remove the clear_checkpoint function during Trial restoration error handling. #48532

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
312406b
remove clear checkpoint
hongpeng-guo Nov 4, 2024
a40b92f
fix faulty unit test of test_tune_restore
hongpeng-guo Nov 5, 2024
8688364
change the unit test back
hongpeng-guo Nov 5, 2024
72e83c9
remove pdb, making num_failures 2
hongpeng-guo Nov 5, 2024
0a376ff
adding documents of the unit test
hongpeng-guo Nov 5, 2024
fe661bb
Merge remote-tracking branch 'origin' into hpguo/v2/tune_restore_fix
hongpeng-guo Nov 5, 2024
0dbb310
Merge remote-tracking branch 'origin' into hpguo/v2/tune_restore_fix
hongpeng-guo Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix faulty unit test of test_tune_restore 
Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
  • Loading branch information
@hongpeng-guo
hongpeng-guo committed Nov 5, 2024
commit a40b92f47fd0ee1832564c9d67cf0afd6fe260c7
4 changes: 2 additions & 2 deletions python/ray/tune/tests/test_tuner_restore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,14 +595,14 @@ def load_checkpoint(self, checkpoint_dir):
failure_config=FailureConfig(max_failures=1),
checkpoint_config=CheckpointConfig(checkpoint_frequency=1),
),
param_space={"tag_file_path": tag_file},
param_space={"tag_file_path": tag_file, "retry_num_to_fail": retry_num},
)
results = tuner.fit()
[result] = list(results)
if retry_num > 0:
assert result.metrics["score"] == 5
else:
assert result.metrics["score"] == 2
assert result.metrics["score"] == 5


def test_restore_overwrite_trainable(ray_start_2_cpus, tmpdir):
Expand Down