Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix Algorithm with tune #48529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smanolloff
Copy link
Contributor

@smanolloff smanolloff commented Nov 4, 2024

Algorithm.__init__() removes TRIAL_INFO from the config before calling super().__init__(), but it's actually needed by Trainable.

I noticed it because self.trial_id incorrectly returns "default" within a tune experiment. Many other tune-related properties are surely broken as well.

This PR essentially reverts a change made 2y ago: #30042, which may have solved some issue back then, but now it just causes one.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…red.

I noticed it because `self.trial_id` incorrectly returns `"default"` within a tune experiment.

This PR essentially reverts a change made 2y ago: ray-project#30042

I assume it may have solved some issue back then, but now it just causes one.

Signed-off-by: Simeon Manolov <s.manolloff@gmail.com>
@smanolloff smanolloff changed the title Tune fails to set some important Trainable properties if this is igno… Fix Algorithm + Tune Nov 4, 2024
@smanolloff smanolloff changed the title Fix Algorithm + Tune Fix Algorithm with tune Nov 4, 2024
@smanolloff smanolloff changed the title Fix Algorithm with tune [rllib] Fix Algorithm with tune Nov 4, 2024
@smanolloff smanolloff changed the title [rllib] Fix Algorithm with tune [RLlib] Fix Algorithm with tune Nov 4, 2024
@jcotant1 jcotant1 added the rllib RLlib related issues label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rllib RLlib related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants