Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] fix yml linter issue #48450

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[rllib] fix yml linter issue #48450

merged 1 commit into from
Nov 1, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Oct 30, 2024 •
edited
Loading

I added linter into precommit hook, which automatically checks trailing whitespace and autofixes.

git push --set-upstream origin hjiang/fix-yml-linter [enter/↑/↓/ctrl+c]
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check toml...........................................(no files to check)Skipped
black................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
prettier.............................................(no files to check)Skipped
mypy.................................................(no files to check)Skipped
isort (python).......................................(no files to check)Skipped
rst directives end with two colons...................(no files to check)Skipped
rst ``inline code`` next to normal text..............(no files to check)Skipped
use logger.warning(..................................(no files to check)Skipped
check for not-real mock methods......................(no files to check)Skipped
ShellCheck v0.9.0....................................(no files to check)Skipped
clang-format.........................................(no files to check)Skipped
Google Java Formatter................................(no files to check)Skipped
Check for Ray docstyle violations....................(no files to check)Skipped
Check for Ray import order violations................(no files to check)Skipped

@dentiny
fix yml linter issue
76d425d 
Signed-off-by: hjiang <hjiang@anyscale.com>
@dentiny dentiny requested review from khluu and can-anyscale October 30, 2024 19:03
khluu
khluu approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@khluu khluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Oct 31, 2024
@dentiny
Copy link
Contributor Author

dentiny commented Oct 31, 2024

@khluu I don't think I have the permission to merge, could you please enable automerge for me? Thank you!

@aslonnie aslonnie self-requested a review November 1, 2024 11:50
@aslonnie aslonnie merged commit ee86218 into ray-project:master Nov 1, 2024
4 of 5 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@dentiny @Jay-ju
[rllib] fix yml linter issue (ray-project#48450)
0c7d659 
linter was added into precommit hook, which automatically checks trailing
whitespace and autofixes.

Signed-off-by: hjiang <hjiang@anyscale.com>
Co-authored-by: hjiang <hjiang@anyscale.com>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@dentiny @JP-sDEV
[rllib] fix yml linter issue (ray-project#48450)
a230342 
linter was added into precommit hook, which automatically checks trailing
whitespace and autofixes.

Signed-off-by: hjiang <hjiang@anyscale.com>
Co-authored-by: hjiang <hjiang@anyscale.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@dentiny @mohitjain2504
[rllib] fix yml linter issue (ray-project#48450)
113eefb 
linter was added into precommit hook, which automatically checks trailing
whitespace and autofixes.

Signed-off-by: hjiang <hjiang@anyscale.com>
Co-authored-by: hjiang <hjiang@anyscale.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khluu khluu khluu approved these changes

@can-anyscale can-anyscale Awaiting requested review from can-anyscale

@aslonnie aslonnie Awaiting requested review from aslonnie

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dentiny @khluu @aslonnie