-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][dag] Add ascii based CG visualization #48315
base: master
Are you sure you want to change the base?
[core][dag] Add ascii based CG visualization #48315
Conversation
@ruisearch42 Hi, can you check this. I just add another method based on ascii and the previous visualization keeps the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I think ASCII visualization only scales to a certain graph size and complexity and would like to get an idea what types of graphs work well for this implementation and what would break.
Hi, @ruisearch42, I just made some modification based on your comments. I think it looks better now. While I prefer to return the sting instead of print so we can run the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had some ideas to make the viz easier to read. After that I will probably have a final round of review for merging.
I just make some fix, can you check these? Thx! |
Why are these changes needed?
Add ascii based CG visualization so we can have better view of the CG.
Related issue number
Close
#48190
Example
codes
output
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.