Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Remove buffer capacity from ShufflingBatcher #48243

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

the ShufflingBatcher._buffer_capacity field is not used anywhere so we can remove it.

Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ArturNiederfahrenhorst ArturNiederfahrenhorst enabled auto-merge (squash) October 25, 2024 10:49
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 25, 2024
@ArturNiederfahrenhorst ArturNiederfahrenhorst merged commit fc34890 into ray-project:master Oct 25, 2024
6 of 7 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
## Why are these changes needed?

the ShufflingBatcher._buffer_capacity field is not used anywhere so we
can remove it.
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
## Why are these changes needed?

the ShufflingBatcher._buffer_capacity field is not used anywhere so we
can remove it.
Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
## Why are these changes needed?

the ShufflingBatcher._buffer_capacity field is not used anywhere so we
can remove it.

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants