Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Rename PolicyEvaluator => RolloutWorker #4820

Merged
merged 26 commits into from
Jun 2, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
ericl committed May 30, 2019
commit 0aac2fd9bc8ffc97cead20940cbf147e20f459d6
4 changes: 2 additions & 2 deletions python/ray/rllib/evaluation/worker_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ def foreach_worker_with_index(self, func):
return local_result + remote_results

@staticmethod
def _from_existing(local_worker, remote_workers):
def _from_existing(local_worker, remote_workers=None):
workers = WorkerSet(None, None, {}, _setup=False)
workers._local_worker = local_worker
workers._remote_workers = remote_workers
workers._remote_workers = remote_workers or []
return workers

def _make_worker(self, cls, env_creator, policy, worker_index, config):
Expand Down
3 changes: 2 additions & 1 deletion python/ray/rllib/tests/test_external_multi_agent_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from ray.rllib.agents.pg.pg_policy import PGTFPolicy
from ray.rllib.optimizers import SyncSamplesOptimizer
from ray.rllib.evaluation.rollout_worker import RolloutWorker
from ray.rllib.evaluation.worker_set import WorkerSet
from ray.rllib.env.external_multi_agent_env import ExternalMultiAgentEnv
from ray.rllib.tests.test_rollout_worker import MockPolicy
from ray.rllib.tests.test_external_env import make_simple_serving
Expand Down Expand Up @@ -75,7 +76,7 @@ def testTrainExternalMultiCartpoleManyPolicies(self):
policy=policies,
policy_mapping_fn=lambda agent_id: random.choice(policy_ids),
batch_steps=100)
optimizer = SyncSamplesOptimizer(ev, [])
optimizer = SyncSamplesOptimizer(WorkerSet._from_existing(ev), [])
for i in range(100):
optimizer.step()
result = collect_metrics(ev)
Expand Down