Convert plasma client array and object notification queue to STL #482
Conversation
pcmoritz
changed the title
pcmoritz
changed the title
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
src/plasma/plasma_store.cc
Outdated
| @@ -28,6 +28,7 @@ | |||
| #include <unordered_map> | |||
| #include <unordered_set> | |||
| #include <vector> | |||
| #include <deque> | |||
There was a problem hiding this comment.
These should be in alphabetical order.
| @@ -72,7 +69,7 @@ typedef struct { | |||
| int subscriber_fd; | |||
| /** The object notifications for clients. We notify the client about the | |||
| * objects in the order that the objects were sealed or deleted. */ | |||
| UT_array *object_notifications; | |||
| std::deque<uint8_t *> *object_notifications; | |||
There was a problem hiding this comment.
How about we make this not a pointer?
There was a problem hiding this comment.
After the next PR where I make the pending_notifications an STL hashmap ;)
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
Contains the STL conversion of @atumanov for the object notification queue in
atumanov@2007ae1