Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit linter errors #47947

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix pre-commit linter errors #47947

merged 1 commit into from
Oct 8, 2024

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Oct 8, 2024 •
edited
Loading

Why are these changes needed?

The pre-commit hooks fail for me locally due to these issues.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
update
4024ca6 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes enabled auto-merge (squash) October 8, 2024 20:09
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 8, 2024
omatthew98
omatthew98 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@edoakes edoakes merged commit 630ec9a into ray-project:master Oct 8, 2024
5 of 6 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@edoakes @ujjawal-khare
Fix pre-commit linter errors (ray-project#47947)
1971677 
The pre-commit hooks fail for me locally due to these issues.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omatthew98 omatthew98 omatthew98 approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee

@bveeramani bveeramani Awaiting requested review from bveeramani

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoakes @omatthew98