[rllib] Fix bounds of space returned by preprocessor.observation_space #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test FAILed. |
|
jenkins test failing - would it make sense to fix in here? |
|
Test PASSed. |
|
Test FAILed. |
richardliaw
approved these changes
May 4, 2019
pengzhenghao
pushed a commit
to pengzhenghao/ray
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It was return -1, 1 before, which is not correct in general. Conservatively include the entire range.
Related issue number
Linter
scripts/format.shto lint the changes in this PR.