Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove actor_register_async config #46998

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 7, 2024

Why are these changes needed?

This has been turned on for 3 years so we can safely remove the old slow actor sync register.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 7, 2024
@jjyao jjyao merged commit 9844797 into ray-project:master Aug 7, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/red branch August 7, 2024 17:01
dev-goyal pushed a commit to dev-goyal/ray that referenced this pull request Aug 8, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Dev <dev.goyal@hinge.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants