Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py312] Fix or skip tests+examples for Tune dependencies that do not support py312 #46761

Merged
merged 31 commits into from
Jul 25, 2024

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Jul 23, 2024

Why are these changes needed?

Policy:

  • Tests for library integrations will be skipped on py312 if that library doesn't support py312.
    • Add this library to a py312 ML issue tracker. (TODO)
  • Tests for library integrations will be skipped altogether if it imposes a version cap on a more important library.
    • For example, numpy needs to be upgraded 1.26+ for py312. However, hebo requries numpy<1.25. Since our CI chooses a single numpy version for across the board, we'd rather update numpy than keep the hebo test dependency.
    • Same issue for horovod.
    • Add this library to a py312 ML issue tracker. Note that these are no longer tested in CI and need to be manually tested. (TODO)
  • Important library integrations that do not support py312 yet will be added to the issue tracker and treated as a medium high priority that needs to be solved as soon as the library adds the py312 support.
    • For example, tensorflow DDP doesn't work well in py312. Whenever this gets fixed, a new tf version should be pinned in test deps and the tests should be re-enabled.

Related issue number

Closes #46220

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

justinvyu added 22 commits July 23, 2024 15:11
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for working on this @justinvyu, i'll leave to @matthewdeng to see if he has any comments for a few days otherwise i'll unblock, thankks

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu changed the title [py312] Skip tests+examples for Tune dependencies that do not support py312 [py312] Fix or skip tests+examples for Tune dependencies that do not support py312 Jul 24, 2024
@justinvyu justinvyu enabled auto-merge (squash) July 24, 2024 21:20
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 24, 2024
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@github-actions github-actions bot disabled auto-merge July 24, 2024 21:39
@@ -95,7 +95,7 @@ def failing(config):

tuner = Tuner(failing)
results = tuner.fit()
assert len(str(results[0].error).split("\n")) <= 12
assert len(str(results[0].error).split("\n")) <= 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py312 adds a bunch of new lines + formatting to stack traces 😆

@justinvyu justinvyu merged commit eac96b5 into ray-project:master Jul 25, 2024
5 checks passed
@justinvyu justinvyu deleted the py312/ml branch July 25, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python 3.12][ml] fix tests for python 3.12
3 participants