Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakequotes to allow escaping quotes #4666

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Fix flakequotes to allow escaping quotes #4666

merged 2 commits into from
Apr 19, 2019

Conversation

justinwyang
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/523/
Test PASSed.

jovany-wang
jovany-wang requested changes Apr 19, 2019
View reviewed changes
jovany-wang
jovany-wang approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be merged once CI passes!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/525/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13862/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13865/
Test FAILed.

@justinwyang
Copy link
Contributor Author

I don't think any of the remaining errors have anything to do with flake-quotes; they seem to be associated with execution. Is it possible to get this feature merged, since I wish to incorporate it in another PR?

@robertnishihara robertnishihara changed the title Fixe flakequotes to allow escaping quotes Fix flakequotes to allow escaping quotes Apr 19, 2019
@robertnishihara robertnishihara merged commit 2f4b784 into ray-project:master Apr 19, 2019
@justinwyang justinwyang deleted the flake-escaping-quotes-fix branch April 19, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinwyang @AmplabJenkins @jovany-wang @robertnishihara