Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] remove pygloo support #46590

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[util] remove pygloo support #46590

wants to merge 10 commits into from

Conversation

aslonnie
Copy link
Collaborator

pygloo support stops at python 3.8, which ray does not support. the pygloo package is effectively already dead

@aslonnie aslonnie requested a review from a team as a code owner July 12, 2024 05:02
@aslonnie aslonnie force-pushed the lonnie-270711-nogloo branch from 000ab7e to 9669ca8 Compare July 12, 2024 05:04
pygloo support stops at python 3.8, which ray does not support.
the pygloo package is effectively already dead

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie force-pushed the lonnie-270711-nogloo branch from 9669ca8 to a1a03eb Compare July 12, 2024 05:11
@aslonnie aslonnie requested review from matthewdeng and jjyao July 12, 2024 05:13
@aslonnie
Copy link
Collaborator Author

(jiajun the great can review everything..)

@jjyao
Copy link
Collaborator

jjyao commented Jul 12, 2024

@jovany-wang is https://github.com/ray-project/pygloo still maintained? I saw you had a commit 2 months ago. If it's still maintained, it needs to support newer version of python.

@jovany-wang
Copy link
Contributor

@jjyao Yes. We are still maintaining it. Do we still need it in Ray in some scenarios?

@jjyao
Copy link
Collaborator

jjyao commented Jul 12, 2024

@jovany-wang can you then make it support python versions 3.9+. The old versions are EOLed.

@jovany-wang
Copy link
Contributor

@jjyao Sure. I'll tell you our plan later.

@jovany-wang
Copy link
Contributor

FYI @Catch-Bull @larrylian

@terraflops1048576
Copy link
Contributor

For what it's worth, I have some use cases for the collective communication on CPU via pygloo, so I hope it doesn't get removed. I managed to get pygloo to build for Python 3.11 by just updating pybind11_bazel and pybind11 in the WORKSPACE file and updating setup.py. It appears to work fine.

This seems like a few hours of work for someone more familiar with Bazel than I am, so I certainly hope that we don't just delete!

@aslonnie aslonnie changed the title [util] delete everything related to pygloo [util] remove pygloo support Jul 12, 2024
@jovany-wang
Copy link
Contributor

@terraflops1048576 Thanks for your feedback.

@jovany-wang
Copy link
Contributor

Let me clarify that if it's worth to have, then we need make it work.

@aslonnie
Copy link
Collaborator Author

Let me clarify that if it's worth to have, then we need make it work.

do we have a timeline?

new wheels (py39 310 311 312) need to be published on pypi.

@aslonnie aslonnie requested a review from jovany-wang July 12, 2024 16:46
@aslonnie aslonnie marked this pull request as draft July 12, 2024 16:46
@aslonnie
Copy link
Collaborator Author

ping, any follow up?

@aslonnie
Copy link
Collaborator Author

fwiw, there is no intersection on python version between ray release and gloo. when gloo starts catching up, we can always revert this change and add gloo back.

@terraflops1048576
Copy link
Contributor

Would sample wheels for Python 3.11 or a hacked together pygloo repository be helpful for updating?

@aslonnie
Copy link
Collaborator Author

Would sample wheels for Python 3.11 or a hacked together pygloo repository be helpful for updating?

how would a ray user use it? why only 3.11?

@terraflops1048576
Copy link
Contributor

As in it's a pretty easy task to build for Python 3.11 (which is the Python that I regularly use for projects). It was a matter of changing the dependencies in the pygloo repository. The code almost all works fine with only minor tweaks. However, it looks like the maintainer hasn't gotten to it.

I can probably build these wheels for all Python versions >= 3.9, but probably not for all platforms.

@aslonnie
Copy link
Collaborator Author

any update?

@larrylian
Copy link
Contributor

larrylian commented Sep 10, 2024 via email

@aslonnie
Copy link
Collaborator Author

Hi, thanks. I will reply to you soon when I'm back.

any update?

@larrylian
Copy link
Contributor

larrylian commented Oct 18, 2024 via email

@aslonnie
Copy link
Collaborator Author

Hi, thanks. I will reply to you soon when I'm back.

and when is that? like is it okay to commit this change and revert this change when you are back and have progress?

the python version that ray supports now has no intersection with pygloo. this code is effectively dead weight in the code base, and we have been waiting for 3 months.

@aslonnie aslonnie marked this pull request as ready for review October 21, 2024 17:37
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Oct 21, 2024
@larrylian
Copy link
Contributor

@aslonnie My apologies for not noticing earlier. I will address this issue within a week and will keep you updated on the progress. I'll try to update pygloo to support python 3.10、3.11...

@larrylian
Copy link
Contributor

@aslonnie I have urgently upgraded the version of PyGloo and it now supports Python versions 3.8, 3.9, and 3.10. In a few days, @jovany-wang will help upload it to the pip repository, and then you will be able to use it normally.

@aslonnie
Copy link
Collaborator Author

aslonnie commented Nov 1, 2024

@aslonnie I have urgently upgraded the version of PyGloo and it now supports Python versions 3.8, 3.9, and 3.10. In a few days, @jovany-wang will help upload it to the pip repository, and then you will be able to use it normally.

thanks. is it released on pypi? or where should user find the release to install?

@aslonnie aslonnie marked this pull request as draft January 2, 2025 00:03
@can-anyscale can-anyscale removed their request for review January 7, 2025 17:15
Copy link

stale bot commented Feb 25, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 25, 2025
@aslonnie aslonnie removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants