Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Use with clause to make sure result json file is closed properly #46484

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 8, 2024

Why are these changes needed?

If the file is not closed correctly, the data might be lost.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

jjyao added 2 commits July 8, 2024 13:09
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao changed the title [Core] missing results [Release] Use with clause to make sure result json file is closed properly Jul 9, 2024
@jjyao jjyao marked this pull request as ready for review July 9, 2024 22:29
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; let's confirm with the release test run

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 10, 2024
@jjyao
Copy link
Collaborator Author

jjyao commented Jul 10, 2024

The issue is fixed




[INFO 2024-07-09 23:15:19,390] log.py: 41  Observed the following results:
  |  
  | broadcast_time = 80.23293005799997
  | object_size = 1073741824
  | num_nodes = 50
  | success = 1
  | perf_metrics = [{'perf_metric_name': 'time_to_broadcast_1073741824_bytes_to_50_nodes', 'perf_metric_value': 80.23293005799997, 'perf_metric_type': 'LATENCY'}]
 

<br class="Apple-interchange-newline">

@jjyao jjyao merged commit 2c5745f into ray-project:master Jul 10, 2024
6 checks passed
@jjyao jjyao deleted the jjyao/perrf branch July 10, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants