Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bazel] Use rules_jvm_external to manage java dependencies #4615

Merged
merged 9 commits into from
Apr 18, 2019
Merged

[Bazel] Use rules_jvm_external to manage java dependencies #4615

merged 9 commits into from
Apr 18, 2019

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Apr 12, 2019 •
edited
Loading

What do these changes do?

Unlike the current bazel-deps tool, rules_jvm_external doesn't need to check in the auto-generated worksapce.bzl file.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/459/
Test PASSed.

@raulchen raulchen requested review from pcmoritz and guoyuhong April 12, 2019 14:36
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13774/
Test FAILed.

guoyuhong
guoyuhong approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much cleaner. Please fix the lint error and resolve the conflicts.

bazel/BUILD.plasma
@@ -17,7 +17,7 @@ java_binary(
visibility = ["//visibility:public"],
deps = [
":org_apache_arrow_arrow_plasma",
"@junit_junit//jar",
"@maven//:junit_junit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use TestNG instead of JUnit, right？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plasma still uses junit.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/494/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/495/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13824/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13823/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/502/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13836/
Test FAILed.

@raulchen raulchen merged commit be2cbdf into ray-project:master Apr 18, 2019
@raulchen raulchen deleted the bazel_deps branch April 24, 2019 06:51
Edilmo added a commit to BonsaiAI/ray that referenced this pull request Feb 10, 2020
@Edilmo
Cherry picking changes from PR 4615
a66fa78 
This PR contains changes that help with memory issues
ray-project#4615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoyuhong guoyuhong guoyuhong approved these changes

@pcmoritz pcmoritz Awaiting requested review from pcmoritz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulchen @AmplabJenkins @guoyuhong