Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[doc]Make vllm example works with latest vllm version" #46094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "[doc]Make vllm example works with latest vllm version" #46094

wants to merge 1 commit into from

Conversation

anyscalesam
Copy link
Contributor

Reverts #45742

@GeneDer
Copy link
Contributor

GeneDer commented Jun 17, 2024

@anyscalesam Can you add some context on why this needs to be reverted? If there are some incompatible issues, maybe we can fix forward? Also DCO is failing🙃

can-anyscale
can-anyscale requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put back to sam's queue for questions

@stale Stale
Copy link

stale bot commented Feb 25, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale requested changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale

@zcin zcin Awaiting requested review from zcin zcin is a code owner

@GeneDer GeneDer Awaiting requested review from GeneDer GeneDer is a code owner

@akshay-anyscale akshay-anyscale Awaiting requested review from akshay-anyscale akshay-anyscale is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anyscalesam @GeneDer @can-anyscale