[autoscaler] Lint code that we forgot to lint in #4537

[hartikainen]

I merged #4537 without linting. This fixes the lint errors.

[AmplabJenkins]

Can one of the admins verify this patch?

[jovany-wang]

Hi @hartikainen, is the following case failure produced by #4537 ?

python/ray/tests/test_autoscaler.py::AutoscalingTest::testReportsConfigFailures FAILED [ 30%]

This is the CI result I met: https://travis-ci.com/ray-project/ray/jobs/191124885

[guoyuhong]

@jovany-wang @hartikainen Yes, it looks like python/ray/tests/test_autoscaler.py::AutoscalingTest::testReportsConfigFailure has reproducible failure. Please also fix that. You can ignore the failure of python/ray/tests/test_stress.py::test_submitting_many_actors_to_one.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13648/
Test FAILed.

[hartikainen]

55e1cdb should fix the test error as well. The problem was that the way we setup some of the autoscaler tests, the setup command merge was not called, and thus some of the commands were not run. I reverted the changes related to the setup command merge. @richardliaw do you mind taking a look (55e1cdb)?

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13664/
Test FAILed.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13663/
Test FAILed.

[hartikainen]

jenkins retest this please

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13668/
Test FAILed.

[guoyuhong]

LGTM. I restarted the failed Travis tests. I will merge this PR once the tests finish.

[hartikainen]

@guoyuhong Don't merge this yet. I think there's still something off with my latest setup_commands change. I'll fix it tomorrow morning.

[hartikainen]

I just pushed a fix for this. Tested on GCP and everything looks good.

[guoyuhong]

@hartikainen That is to say I can merge this PR if the test passed, right?

[hartikainen]

@guoyuhong Yep!

[guoyuhong]

@hartikainen OK, I will keep an eye on it. This PR is better to get merged as soon as possible to unblock other PRs.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13684/
Test FAILed.

[AmplabJenkins]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13685/
Test FAILed.

[guoyuhong]

This looks good. I will merge it.

[ericl]

Ah, thanks for fixing. Next time, we can merge hotfixes such as this immediately.