Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in kuber yaml #4582

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fixed typo in kuber yaml #4582

merged 1 commit into from
Apr 9, 2019

Conversation

DuaneNielsen
Copy link
Contributor

@DuaneNielsen DuaneNielsen commented Apr 8, 2019

What do these changes do?

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@DuaneNielsen
Copy link
Contributor Author

Okies, here tis

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@robertnishihara
Copy link
Collaborator

@virtualluke Does this look right to you?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13642/
Test FAILed.

@DuaneNielsen
Copy link
Contributor Author

Lol, dunno how that change can cause a test to fail :)

@robertnishihara robertnishihara merged commit 7f23e84 into ray-project:master Apr 9, 2019
@robertnishihara
Copy link
Collaborator

Thanks @DuaneNielsen! Some of our tests are flaky unfortunately.

What command did you use to validate the config file? Maybe we should run that in our CI.

@virtualluke
Copy link
Contributor

Sorry for the typo, to put a test I guess we could add a minikube run with the files (adds a lot of complexity I guess with k8s versions/platform), guessing other people have done that for testing and if you think it worthwhile I can explore. Anyone else done this that is reading this?

@DuaneNielsen
Copy link
Contributor Author

Well, I just ran

kubectl create -f ray/kubernetes/head.yaml

I only got a warning though... so dunno if that would even cause a failed build.

But a quick google reveals we are not the first to run into this challenge. So through the wonders of open source...

https://github.com/garethr/kubeval

@robertnishihara
Copy link
Collaborator

I also ran the PR that introduced the typo in minikube before merging it and it still succeeded.

@ikedaosushi ikedaosushi mentioned this pull request May 26, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants