[autoscaler] Remove unnecessary apt installations in docker commands #4577
Conversation
|
Can one of the admins verify this patch? |
|
@richardliaw I pushed couple of minor changes to the gcp autoscaler configs. I tested both changed examples and they work as expected. |
| @@ -85,7 +85,7 @@ worker_nodes: | |||
| initializeParams: | |||
| diskSizeGb: 50 | |||
| # See https://cloud.google.com/compute/docs/images for more images | |||
| sourceImage: projects/ml-images/global/images/family/tf-1-13-gpu | |||
| sourceImage: projects/deeplearning-platform-release/global/images/family/tf-1-13-cpu | |||
There was a problem hiding this comment.
Related to #4524. Seems like deeplearning-platform-release is more standard than ml-images. I also changed this from gpu to cpu to be consistent with the aws example. cc @toanngosy.
richardliaw
changed the title
hartikainen
force-pushed
the
remove-unnecessary-apt-get-call-in-docker
branch
from
e0e6b81 to
00d3a14
Compare
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
hartikainen
force-pushed
the
remove-unnecessary-apt-get-call-in-docker
branch
from
00d3a14 to
cefaecc
Compare
|
Test FAILed. |
What do these changes do?
Removes unnecessary
apt-get installfrom autoscaler setup docker commands. These commands are problematic if the docker container is run as some other user than root. I believe there's no particular reason we install these packages so it seems better to just get rid of them.Linter
scripts/format.shto lint the changes in this PR.