Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Improve PBT example #4575

Merged
merged 5 commits into from
Apr 10, 2019
Merged

[tune] Improve PBT example #4575

merged 5 commits into from
Apr 10, 2019

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Apr 7, 2019

No description provided.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/395/
Test PASSed.

richardliaw
richardliaw reviewed Apr 7, 2019
View reviewed changes
python/ray/tune/examples/pbt_example.py
hyperparam_mutations={
# Allow for scaling-based perturbations, with a uniform backing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there should be at least one example that showcases the many features of PBT. Maybe this triangle LR example should be a separate file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I actually think it's better to have one good example. As a compromise, I added factor_2 back here. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now; I think a better fix later is to have a very comprehensive walkthrough page in the Ray Examples section on how exactly to use PBT.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13623/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/402/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13670/
Test FAILed.

richardliaw and others added 2 commits April 9, 2019 20:58
@richardliaw @ericl
Update python/ray/tune/examples/pbt_example.py
9078168 
Co-Authored-By: ericl <ekhliang@gmail.com>
@ericl
cleanup
462d6ba
@ericl ericl merged commit f8e8743 into ray-project:master Apr 10, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13679/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @richardliaw