Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] log dedup should not dedup number only lines #45485

Merged
merged 3 commits into from
May 24, 2024
Merged

[core] log dedup should not dedup number only lines #45485

merged 3 commits into from
May 24, 2024

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented May 21, 2024 •
edited
Loading

Why are these changes needed?

Ray runtime in driver deduplicates similar logs from all workers by default. In this case, all numbers are canonicalized, i.e. treated equal.

If all that prints are just numbers, it would be really bad user experience to dedup them. Because that's all the information that users want to see. If they can't see them, they will be confused.

Related issue number

Fix #45262

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@hongchaodeng
[core] log dedup should not dedup number only lines
6be5d85 
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
@hongchaodeng
add test
5a6a88d 
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
@hongchaodeng hongchaodeng added the go add ONLY when ready to merge, run all tests label May 21, 2024
@hongchaodeng hongchaodeng mentioned this pull request May 21, 2024
Closed
rynewang
rynewang reviewed May 24, 2024
View reviewed changes
python/ray/tests/test_log_dedup.py
"ip": "node1",
"pid": 100,
# numbers are canonicalised, so this would lead to empty dedup_key
"lines": ["1"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are testing LogDeduplicator can you add more duplicate lines? like 2 then 2 and all are outputed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hongchaodeng
comments
047b8e7 
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
jjyao
jjyao approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the PR description explaining what the issue is

@jjyao jjyao enabled auto-merge (squash) May 24, 2024 04:29
@jjyao jjyao merged commit 4851df7 into ray-project:master May 24, 2024
7 checks passed
@hongchaodeng hongchaodeng deleted the fix-tasklog branch May 24, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynewang rynewang rynewang approved these changes

@jjyao jjyao jjyao approved these changes

@rkooo567 rkooo567 Awaiting requested review from rkooo567

Assignees

@jjyao jjyao

@rynewang rynewang

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Buffered logs lost sometimes
3 participants
@hongchaodeng @jjyao @rynewang