Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Tune] Remove duplicate new Tune output CI pipeline #44859

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

hongpeng-guo
Copy link
Contributor

@hongpeng-guo hongpeng-guo commented Apr 19, 2024

Why are these changes needed?

We have a duplicate CI pipeline for the new output engine, even though it's already enabled by default. There's no need for the duplicate pipeline. This PR removes the repeated CI pipeline.

Related issue number

Closes #44775

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hongpeng Guo <hpguo@anyscale.com>
@hongpeng-guo
Copy link
Contributor Author

Please let me know how to unit test buidkite changes. Thx! :)

@justinvyu
Copy link
Contributor

@hongpeng-guo Take a look at buildkite/premerge -> Details, then make sure you don't see the tune new output tests being run anywhere.

@hongpeng-guo hongpeng-guo changed the title [CI][Tune] Remove duplicate new Tune output CI pipeline (#44775) [CI][Tune] Remove duplicate new Tune output CI pipeline Apr 19, 2024
@hongpeng-guo
Copy link
Contributor Author

@hongpeng-guo Take a look at buildkite/premerge -> Details, then make sure you don't see the tune new output tests being run anywhere.

@justinvyu Just double checked and confirmed that tune new output tests was removed in buildkite/premerge :)

Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@justinvyu justinvyu merged commit aee9217 into ray-project:master Apr 19, 2024
5 checks passed
@hongpeng-guo hongpeng-guo deleted the dev2 branch April 19, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tune] Remove duplicate new Tune output CI pipeline
4 participants