Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs] Streamlining log-tailing sequence #44658

Merged
merged 5 commits into from
Apr 12, 2024
Merged

[Logs] Streamlining log-tailing sequence #44658

merged 5 commits into from
Apr 12, 2024

Conversation

alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Apr 11, 2024 •
edited
Loading

Changes

Revisited log-tailing sequence to

  • Get it streamlined and simplified
  • Avoid busy-looping when reached EOF (instead doing 1s sleeps)

Related issue number

Addresses #44659

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alexeykudinkin
Revisited log-tailing sequence to
51bf04c 
 - Get it streamlined and simplified
 - Avoid busy-looping when reached EOF (instead doing 1s sleeps)

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
lint
abd563f 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin alexeykudinkin requested a review from alanwguo April 11, 2024 01:56
@alexeykudinkin
Fixed NPE
7717615 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin
Fixed tests
81f8b6c 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
@alexeykudinkin alexeykudinkin linked an issue Apr 11, 2024 that may be closed by this pull request
[Dashboard] Log tailer busy spins when reaches EOF #44659
Closed
@alexeykudinkin
lint
7a473c9 
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
alanwguo
alanwguo approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. lgtm

@jjyao jjyao merged commit 3c8e931 into master Apr 12, 2024
5 checks passed
@jjyao jjyao deleted the ak/log-tail-fix branch April 12, 2024 00:37
@rynewang rynewang mentioned this pull request Sep 18, 2024
Merged
@kevin85421 kevin85421 mentioned this pull request Sep 29, 2024
Merged
4 tasks
@andrewsykim andrewsykim mentioned this pull request Feb 14, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwguo alanwguo alanwguo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Log tailer busy spins when reaches EOF
3 participants
@alexeykudinkin @alanwguo @jjyao