Avoid redundant bazel build #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
commented
Mar 22, 2019
| @@ -1,2 +1,4 @@ | |||
| # build config | |||
| build --compilation_mode=opt | |||
| build --action_env=PATH | |||
There was a problem hiding this comment.
It is still needed, otherwise we can't guarantee which python will be picked up if there are multiple ones.
There was a problem hiding this comment.
ok, just noticed that the build.sh script takes a -p option.
guoyuhong
approved these changes
Mar 22, 2019
|
Java CI time reduced from 32min to 17min |
|
Can one of the admins verify this patch? |
|
Test FAILed. |
pcmoritz
approved these changes
Mar 22, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bazel will invalidate caches if the command-line options are different. This PR puts all needed
action_envs in the.bazelrcfile to avoid cache invalidation.Related issue number