-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[travis] Add back '-v' option to pytest and install psutil #4430
Conversation
Can one of the admins verify this patch? |
.travis.yml
Outdated
- python -m pytest -v --durations=5 python/ray/tests/test_mini.py | ||
- python -m pytest -v --durations=5 python/ray/tests/test_array.py | ||
- python -m pytest -v --durations=5 python/ray/tests/test_multi_node_2.py | ||
- python -m pytest -v --durations=5 python/ray/tests/test_node_manager.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wrap these in ci/suppress_output
then?
It will hide the durations though, but will print output if the test hangs.
I think there is also a way to set a global timeout in pytest: https://pypi.org/project/pytest-timeout/1.2.1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci/suppress_output
will also hide the progress. Considering -v
only adds 450-ish lines, I think that is fine?
And the global timeout is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's see how it goes. I think this might be ok (mobile browsers seems to start choking only at a couple thousand lines).
Test FAILed. |
This reverts commit f287249.
Test PASSed. |
Test FAILed. |
What do these changes do?
-v
option. So when a test hangs, we know which test it is.Related issue number