Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Add back '-v' option to pytest and install psutil #4430

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

raulchen
Copy link
Contributor

What do these changes do?

  • Add back the -v option. So when a test hangs, we know which test it is.
  • pip install psutil to suppress the verbose warning log.

Related issue number

@raulchen raulchen requested a review from ericl March 20, 2019 07:46
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

.travis.yml Outdated
- python -m pytest -v --durations=5 python/ray/tests/test_mini.py
- python -m pytest -v --durations=5 python/ray/tests/test_array.py
- python -m pytest -v --durations=5 python/ray/tests/test_multi_node_2.py
- python -m pytest -v --durations=5 python/ray/tests/test_node_manager.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap these in ci/suppress_output then?

It will hide the durations though, but will print output if the test hangs.

I think there is also a way to set a global timeout in pytest: https://pypi.org/project/pytest-timeout/1.2.1/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci/suppress_output will also hide the progress. Considering -v only adds 450-ish lines, I think that is fine?
And the global timeout is a good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's see how it goes. I think this might be ok (mobile browsers seems to start choking only at a couple thousand lines).

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13087/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13133/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13139/
Test FAILed.

@raulchen raulchen merged commit 80cd9c9 into ray-project:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants