Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-call-stack problem of glog #4395

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Conversation

guoyuhong
Copy link
Contributor

What do these changes do?

The official glog bazel script only keeps minimal options to build glog, which has not enabled the call stack. May it is hard to add these options to Glog GitHub. We have 2 options to do this:

  1. Keep these files by ourselves and modify them.
  2. Fork a glog repo in ray-project and modify them in that repo and we can point the glog repo to our forked repo.

This PR chooses the 1st option.

Related issue number

#4347

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12974/
Test PASSed.

@pcmoritz
Copy link
Contributor

@guoyuhong Thanks! This fixes the stacktrace for the raylet for me. The one in the _raylet.so still seems to be broken, maybe copts = COPTS also needs to be added to the _raylet library?

Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the behavior for the client library is actually the same as it was in the past for the CMake build (they both use the plasma client library which comes with arrow and doesn't have the backtrace functionality). I also made sure there is no regression of #4277.

@pcmoritz pcmoritz merged commit edb063c into ray-project:master Mar 19, 2019
@guoyuhong guoyuhong deleted the fixGlogBazel branch March 19, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants