-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Remove external storage upon sigterm for ray start #43941
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make the call blocking & have some timeout (maybe 10 seconds or sth) so that the callback part is not messed up with shutdown path
7957141
to
180130f
Compare
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Why are these changes needed?
Currently, spilled directories are destroyed only when driver cluster (ray.init) is terminated, but not cluster started by ray start.
This PR fixes the issue by always removing external storage upon SIGTERM by calling IO worker.
Related issue number
Closes #17790
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.