Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove external storage upon sigterm for ray start #43941

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ruisearch42
Copy link
Contributor

Why are these changes needed?

Currently, spilled directories are destroyed only when driver cluster (ray.init) is terminated, but not cluster started by ray start.

This PR fixes the issue by always removing external storage upon SIGTERM by calling IO worker.

Related issue number

Closes #17790

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 requested a review from rkooo567 March 13, 2024 00:28
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the call blocking & have some timeout (maybe 10 seconds or sth) so that the callback part is not messed up with shutdown path

src/ray/raylet/node_manager.cc Show resolved Hide resolved
python/ray/_raylet.pyx Outdated Show resolved Hide resolved
@rkooo567 rkooo567 self-assigned this Mar 13, 2024
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 13, 2024
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 changed the title [Core] Remove external storage upone sigterm for ray start [Core] Remove external storage upon sigterm for ray start Mar 14, 2024
Copy link

stale bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 22, 2024
@ruisearch42 ruisearch42 removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Object Spilling] Remove the spilled directory upon Sigterm for ray start
2 participants