Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Flip sign of A2C, IMPALA entropy coefficient; raise DeprecationWarning if negative #4374

Merged
merged 5 commits into from
Mar 18, 2019

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 15, 2019

What do these changes do?

Throw an error if we end up penalizing entropy, which is probably unintended. Other options here:

  1. break backwards compat by renaming the config
  2. always take the absolute value here?

Related issue number

Closes #4369

@ericl ericl changed the title [rllib] Check sign of entropy coefficient [rllib] Flip sign of A2C, IMPALA entropy coefficient; add DeprecationWarning if negative Mar 15, 2019
@ericl ericl changed the title [rllib] Flip sign of A2C, IMPALA entropy coefficient; add DeprecationWarning if negative [rllib] Flip sign of A2C, IMPALA entropy coefficient; raise DeprecationWarning if negative Mar 15, 2019
@ericl
Copy link
Contributor Author

ericl commented Mar 15, 2019

Upon further thought, we can actually safely flip the sign, by raising DeprecationWarning if it's negative.

This is probably the better long-term solution, but should be reviewed carefully.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/91/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/94/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12893/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/102/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12912/
Test FAILed.

@ericl
Copy link
Contributor Author

ericl commented Mar 16, 2019

jenkins retest this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/109/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12922/
Test FAILed.

@ericl
Copy link
Contributor Author

ericl commented Mar 17, 2019

jenkins retest this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/126/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12946/
Test FAILed.

@ericl ericl merged commit 27cd6ea into ray-project:master Mar 18, 2019
internetcoffeephone added a commit to internetcoffeephone/sequential_social_dilemma_games that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants