Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] recompile pip dependencies #42867

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[ci] recompile pip dependencies #42867

merged 1 commit into from
Jan 31, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jan 31, 2024

Recompile requirements_compiled.txt, as requested by @matthewdeng. By removing the line rm ./python/requirements_compiled.txt, it tries to not change the existing file as much as possible.

Test:

  • CI

@can-anyscale can-anyscale force-pushed the can-dep branch 3 times, most recently from 6cc555e to 59f81ad Compare January 31, 2024 10:05
@can-anyscale can-anyscale changed the title [ci] recompile pip dependencies with python 3.8 [ci] recompile pip dependencies Jan 31, 2024
@can-anyscale can-anyscale requested review from matthewdeng and a team January 31, 2024 10:08
@can-anyscale can-anyscale marked this pull request as ready for review January 31, 2024 10:09
@@ -10,7 +10,6 @@ steps:
- label: ":tapioca: build: pip-compile dependencies"
instance_type: small
commands:
- rm ./python/requirements_compiled.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you leave a comment here? I think the intention for removing python/requirements_compiled.txt is that it will capture upgrades.

Signed-off-by: can <can@anyscale.com>
@can-anyscale
Copy link
Collaborator Author

added comments

Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


via NFL on GIPHY

@can-anyscale can-anyscale merged commit 1c8da0b into master Jan 31, 2024
9 checks passed
@can-anyscale can-anyscale deleted the can-dep branch January 31, 2024 22:59
shrekris-anyscale pushed a commit to shrekris-anyscale/ray that referenced this pull request Feb 1, 2024
Recompile requirements_compiled.txt, as requested by @matthewdeng. By removing the line rm ./python/requirements_compiled.txt, it tries to not change the existing file as much as possible.

Signed-off-by: can <can@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants