Skip to content

[Java] Refine tests and fix single-process mode #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 7, 2019
Merged

[Java] Refine tests and fix single-process mode #4265

merged 18 commits into from
Mar 7, 2019

Conversation

@raulchen
Copy link
Contributor

@raulchen raulchen commented Mar 5, 2019 •
edited
Loading

What do these changes do?

  • SkipException cannot be thrown from setUp, otherwise all remaining tests will be skipped. We didn't catch a bug because of this.
  • Fix a bug under single-process mode.
  • Fix the bug that MultiLanguageClusterTest isn't actually running in Travis.
  • Refine script and test code.

Related issue number

@raulchen raulchen requested a review from guoyuhong March 5, 2019 08:35
@raulchen raulchen changed the title [Java] Skip MultiLanguageClusterTest in single-process mode test [wip] [Java] Fix single-process mode Mar 5, 2019
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12560/
Test FAILed.

@raulchen raulchen changed the title [wip] [Java] Fix single-process mode [Java] Refine tests and fix single-process mode Mar 5, 2019
@raulchen raulchen requested a review from jovany-wang March 5, 2019 11:22
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12562/
Test FAILed.

jovany-wang
jovany-wang reviewed Mar 5, 2019
View reviewed changes
java/test/src/main/java/org/ray/api/test/BaseTest.java Outdated
Copy link
Contributor

@jovany-wang jovany-wang Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also log the current mode in this log?
==== Running test: A.b [Cluster]

Copy link
Contributor Author

@raulchen raulchen Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not very useful. we can also find the mode from the command.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12563/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 5, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12564/
Test FAILed.

@raulchen raulchen force-pushed the fix_single_process branch from 25c5aa0 to 715e135 Compare March 6, 2019 04:34
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12584/
Test FAILed.

guoyuhong
guoyuhong reviewed Mar 6, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a question.

java/test.sh Outdated
# Skip compiling the binaries if `--skip-compile` is passed in.
if [[ "$@" != *--skip-compile* ]]; then
echo "Compiling binaries."
$ROOT_DIR/../build.sh -l python,java
Copy link
Contributor

@guoyuhong guoyuhong Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems not to install python ray (just build) and which ray may still be missing.

Copy link
Contributor Author

@raulchen raulchen Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added ./ci/travis/install-ray.sh in the java job, which will install ray. However these 2 commands will do build.sh twice. I'll merge them in the next PR.

Copy link
Contributor Author

@raulchen raulchen Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, fixed in this PR.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12587/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12586/
Test FAILed.

@raulchen raulchen mentioned this pull request Mar 6, 2019
Merged
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12588/
Test FAILed.

raulchen added 3 commits March 6, 2019 16:51
@raulchen
fix ray.home
f4937c3
@raulchen
Revert "format"
8d46612 
This reverts commit 287fbed.
@raulchen
Revert "debug"
ef29910 
This reverts commit a8b60b0.
@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12593/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12595/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12596/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 6, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12599/
Test FAILed.

@raulchen raulchen merged commit f0465bc into ray-project:master Mar 7, 2019
@raulchen raulchen deleted the fix_single_process branch March 7, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jovany-wang jovany-wang jovany-wang left review comments

@guoyuhong guoyuhong guoyuhong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raulchen @AmplabJenkins @jovany-wang @guoyuhong