Skip to content

[Java] Single-process mode #4245

Merged
raulchen merged 4 commits into
ray-project:masterfrom
antgroup:dev_mergeSingleProcess
Mar 5, 2019
Merged

[Java] Single-process mode #4245
raulchen merged 4 commits into
ray-project:masterfrom
antgroup:dev_mergeSingleProcess

Conversation

@bibabolynn

@bibabolynn bibabolynn commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

@raulchen please help review

What do these changes do?

  1. single process mode supports multiple threads
    2.complete methods under single process mode such as:
    submitTask
    wait
    freePlasma

3.add mvn test -Dray.run-mode=SINGLE_PROCESS in test.sh

Related issue number

raulchen
raulchen requested changes Mar 4, 2019
View reviewed changes

@raulchen raulchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code doesn't seem to be well formatted. you can run mvn checkstyle:check locally to find lint problems.

Comment thread java/runtime/src/main/java/org/ray/runtime/objectstore/MockObjectStore.java Outdated

@Override
public byte[] get(byte[] objectId, int timeoutMs, boolean isMetadata) {
return new byte[0];

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to fix this?

Comment thread java/runtime/src/main/resources/ray.default.conf Outdated
// ----------------------------
// configurations under SINGLE_PROCESS mode
// ----------------------------
dev-runtime{

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

Comment thread java/test/src/main/java/org/ray/api/test/MultiThreadingTest.java Outdated
@Override
public void beforeEachCase() {
TestUtils.skipTestUnderSingleProcess();
}

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should work under single-process mode

Comment thread java/test/src/main/java/org/ray/api/test/ObjectStoreTest.java Outdated
@Override
public void beforeEachCase() {
TestUtils.skipTestUnderSingleProcess();
}

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also work.

Comment thread java/runtime/src/main/java/org/ray/runtime/config/RayConfig.java Outdated
driverResourcePath = null;
}

// number of threads that execute tasks under SINGLE_PROCESS mode

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// number of threads that execute tasks under SINGLE_PROCESS mode
// Number of threads that execute tasks under SINGLE_PROCESS mode.

Also apply to other places.

Comment thread java/test.sh Outdated
mvn test | tee mvn_test
if [ `grep -c "BUILD FAILURE" mvn_test` -eq '0' ]; then
rm mvn_test
echo "Run well with CLUSTER mode!"

@raulchen raulchen Mar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Run well with CLUSTER mode!"
echo "Tests passed under CLUSTER mode!"

@AmplabJenkins

AmplabJenkins commented Mar 4, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12527/
Test FAILed.

raulchen
raulchen approved these changes Mar 5, 2019
View reviewed changes

@raulchen raulchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulchen raulchen changed the title [java]single process mode [java] Single-process mode Mar 5, 2019
@raulchen raulchen changed the title [java] Single-process mode [Java] Single-process mode Mar 5, 2019
@AmplabJenkins

AmplabJenkins commented Mar 5, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12547/
Test FAILed.

@raulchen raulchen merged commit c73d508 into ray-project:master Mar 5, 2019
@raulchen raulchen deleted the dev_mergeSingleProcess branch March 5, 2019 05:50
@AmplabJenkins

AmplabJenkins commented Mar 5, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12549/
Test FAILed.

@AmplabJenkins

AmplabJenkins commented Mar 5, 2019

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12550/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulchen raulchen raulchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bibabolynn @AmplabJenkins @raulchen