Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Single-process mode #4245

Merged
merged 4 commits into from
Mar 5, 2019
Merged

[Java] Single-process mode #4245

merged 4 commits into from
Mar 5, 2019

Conversation

bibabolynn
Copy link
Contributor

@raulchen please help review

What do these changes do?

  1. single process mode supports multiple threads
    2.complete methods under single process mode such as:
    submitTask
    wait
    freePlasma

3.add mvn test -Dray.run-mode=SINGLE_PROCESS in test.sh

Related issue number

raulchen
raulchen requested changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code doesn't seem to be well formatted. you can run mvn checkstyle:check locally to find lint problems.

java/runtime/src/main/java/org/ray/runtime/objectstore/MockObjectStore.java Outdated
}
}

@Override
public byte[] get(byte[] objectId, int timeoutMs, boolean isMetadata) {
return new byte[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to fix this?

java/runtime/src/main/resources/ray.default.conf Outdated
// ----------------------------
// configurations under SINGLE_PROCESS mode
// ----------------------------
dev-runtime{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before {

java/test/src/main/java/org/ray/api/test/MultiThreadingTest.java Outdated
@Override
public void beforeEachCase() {
TestUtils.skipTestUnderSingleProcess();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should work under single-process mode

java/test/src/main/java/org/ray/api/test/ObjectStoreTest.java Outdated
@Override
public void beforeEachCase() {
TestUtils.skipTestUnderSingleProcess();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also work.

java/runtime/src/main/java/org/ray/runtime/config/RayConfig.java Outdated
@@ -196,6 +201,9 @@ public RayConfig(Config config) {
driverResourcePath = null;
}

// number of threads that execute tasks under SINGLE_PROCESS mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// number of threads that execute tasks under SINGLE_PROCESS mode
// Number of threads that execute tasks under SINGLE_PROCESS mode.

Also apply to other places.

java/test.sh Outdated
mvn test | tee mvn_test
if [ `grep -c "BUILD FAILURE" mvn_test` -eq '0' ]; then
rm mvn_test
echo "Run well with CLUSTER mode!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Run well with CLUSTER mode!"
echo "Tests passed under CLUSTER mode!"

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12527/
Test FAILed.

raulchen
raulchen approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulchen raulchen changed the title [java]single process mode [java] Single-process mode Mar 5, 2019
@raulchen raulchen changed the title [java] Single-process mode [Java] Single-process mode Mar 5, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12547/
Test FAILed.

@raulchen raulchen merged commit c73d508 into ray-project:master Mar 5, 2019
@raulchen raulchen deleted the dev_mergeSingleProcess branch March 5, 2019 05:50
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12549/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12550/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bibabolynn @AmplabJenkins @raulchen