[ci] remove boost as a ray bazel dependency #42226
Conversation
Signed-off-by: can <can@anyscale.com>
can-anyscale
changed the title
|
will this change the boost version? is that okay? |
|
The nelhage points to the same boost version 1.81.0 https://github.com/nelhage/rules_boost/blob/57c99395e15720e287471d79178d36a85b64d6f6/boost/boost.bzl#L213 |
|
And all test passes I guess |
| name = "boost", | ||
| build_file = "@com_github_nelhage_rules_boost//:BUILD.boost", | ||
| sha256 = "71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa", | ||
| url = "https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.bz2", |
There was a problem hiding this comment.
I can you can also do the same by pointing it to:
so that the version pin is explicitly?
it is weird that the sha256 are different from
seems that it should be the same url.
There was a problem hiding this comment.
ah, this one was use bz2, and that one is using tgz.
There was a problem hiding this comment.
I think unless we want to pin a different version, we should piggy back on the version com_github_nelhage_rules_boost pick going forward and remove the management of this dependency on our side. We end up to be the only person on the internet having this broken by doing something custom.
The current boost rule is busted in master branch: https://buildkite.com/ray-project/postmerge/builds/2404#018ce49f-f8c1-4518-9d32-868a5a4decc6/176-281. Historically, we need to separate the boost rule from com_github_nelhage_rules_boost since we need a patch. This is no longer the case since ray-project#32550. Signed-off-by: can <can@anyscale.com>
The current boost rule is busted in master branch: https://buildkite.com/ray-project/postmerge/builds/2404#018ce49f-f8c1-4518-9d32-868a5a4decc6/176-281. Historically, we need to separate the boost rule from com_github_nelhage_rules_boost since we need a patch. This is no longer the case since #32550.
Test: