Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make putting large objects work. #411

Merged
merged 34 commits into from
Apr 5, 2017
Merged

Make putting large objects work. #411

merged 34 commits into from
Apr 5, 2017

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Mar 29, 2017 •
edited by robertnishihara
Loading

This should address #412.

@pcmoritz pcmoritz changed the title Make putting large objects work [WIP] Make putting large objects work Mar 29, 2017
@robertnishihara
Copy link
Collaborator

robertnishihara commented Mar 30, 2017 •
edited
Loading

Let's hold off on merging this due to https://issues.apache.org/jira/browse/ARROW-739. Although actually this problem may already be present in the Arrow commit in the current master.

@robertnishihara
Copy link
Collaborator

Since https://issues.apache.org/jira/browse/ARROW-739 was addressed by apache/arrow@ad8a0cf, can you change this patch to use the most recent arrow commit?

@robertnishihara robertnishihara mentioned this pull request Apr 1, 2017
Closed
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/470/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/476/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/477/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/478/
Test PASSed.

robertnishihara
robertnishihara reviewed Apr 4, 2017
View reviewed changes
test/jenkins_tests/run_multi_node_tests.sh
@@ -12,3 +12,9 @@ python $ROOT_DIR/multi_node_docker_test.py \
--docker-image=$DOCKER_SHA \
--num-nodes=5 \
--test-script=/ray/test/jenkins_tests/multi_node_tests/test_0.py

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the tests in Jenkins may just be that we were starting the docker image with a small amount of shared memory (1GB), so maybe it would be sufficient to just increase that number.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/497/
Test PASSed.

@robertnishihara robertnishihara changed the title [WIP] Make putting large objects work Make putting large objects work Apr 5, 2017
@robertnishihara robertnishihara changed the title Make putting large objects work Make putting large objects work. Apr 5, 2017
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/498/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/499/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/501/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/503/
Test PASSed.

@robertnishihara robertnishihara merged commit 4043769 into ray-project:master Apr 5, 2017
@robertnishihara robertnishihara deleted the large-objects branch April 5, 2017 08:04
@robertnishihara robertnishihara mentioned this pull request Apr 5, 2017
Closed
@pcmoritz
Copy link
Contributor Author

pcmoritz commented Apr 5, 2017

This validates that arrow's large object support apache/arrow#455 and apache/arrow#404 is working for us end-to-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @robertnishihara @AmplabJenkins