-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Upgrade redis to 7.2.2 and spdlog to 1.12.0 #40852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
approved these changes
Nov 1, 2023
rkooo567
approved these changes
Nov 1, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
Upgrade redis and spdlog so that ray can be compiled on mac 13.5.2+. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Toad2186
added a commit
to hyperscience/ray
that referenced
this pull request
Jan 17, 2024
* Technically we only need `absl` because it was using deprecated C++ APIs that were throwing an error, but I decided to pull: ray-project#31925 No functional changes, still debating whether we should increase the suffix -- leaving as is for now * Also update `spdlog`, for the same reason, based on this PR: ray-project#40852
Toad2186
added a commit
to hyperscience/ray
that referenced
this pull request
Jan 23, 2024
* Technically we only need `absl` because it was using deprecated C++ APIs that were throwing an error, but I decided to pull: ray-project#31925 No functional changes, still debating whether we should increase the suffix -- leaving as is for now * Also update `spdlog`, for the same reason, based on this PR: ray-project#40852
Toad2186
added a commit
to hyperscience/ray
that referenced
this pull request
Feb 8, 2024
* Update `redis`, from ray-project#40852. Otherwise, it won't build on newer Mac versions.
xs0ul
pushed a commit
to hyperscience/ray
that referenced
this pull request
Jul 29, 2024
* Update `redis`, from ray-project#40852. Otherwise, it won't build on newer Mac versions.
anvdn
pushed a commit
to hyperscience/ray
that referenced
this pull request
Oct 16, 2024
* Update `redis`, from ray-project#40852. Otherwise, it won't build on newer Mac versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Upgrade redis and spdlog so that ray can be compiled on mac 13.5.2+.
Related issue number
Closes #39906
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.