Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Upgrade redis to 7.2.2 and spdlog to 1.12.0 #40852

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Nov 1, 2023

Why are these changes needed?

Upgrade redis and spdlog so that ray can be compiled on mac 13.5.2+.

Related issue number

Closes #39906

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Jiajun Yao and others added 2 commits November 1, 2023 08:37
@jjyao jjyao merged commit f811e3e into ray-project:master Nov 1, 2023
@jjyao jjyao deleted the jjyao/sonoma branch November 1, 2023 22:50
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Upgrade redis and spdlog so that ray can be compiled on mac 13.5.2+.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Toad2186 added a commit to hyperscience/ray that referenced this pull request Jan 17, 2024
* Technically we only need `absl` because it was using deprecated C++
APIs that were throwing an error, but I decided to pull:
ray-project#31925
No functional changes, still debating whether we should increase
the suffix -- leaving as is for now
* Also update `spdlog`, for the same reason, based on this PR:
ray-project#40852
Toad2186 added a commit to hyperscience/ray that referenced this pull request Jan 23, 2024
* Technically we only need `absl` because it was using deprecated C++
APIs that were throwing an error, but I decided to pull:
ray-project#31925
No functional changes, still debating whether we should increase
the suffix -- leaving as is for now
* Also update `spdlog`, for the same reason, based on this PR:
ray-project#40852
Toad2186 added a commit to hyperscience/ray that referenced this pull request Feb 8, 2024
* Update `redis`, from ray-project#40852.
  Otherwise, it won't build on newer Mac versions.
xs0ul pushed a commit to hyperscience/ray that referenced this pull request Jul 29, 2024
* Update `redis`, from ray-project#40852.
  Otherwise, it won't build on newer Mac versions.
anvdn pushed a commit to hyperscience/ray that referenced this pull request Oct 16, 2024
* Update `redis`, from ray-project#40852.
  Otherwise, it won't build on newer Mac versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Fix building Ray from source code on mac 13.5.2+ and clang 15+
3 participants