[ci] fix minimal test flakiness #40492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-test-4
branch
2 times, most recently
from
87928a6 to
a1228a3
Compare
can-anyscale
changed the title
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-test-4
branch
from
a1228a3 to
c2ed919
Compare
aslonnie
approved these changes
Oct 19, 2023
rkooo567
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated the minimal test run to civ2, we run all minimal tests with two flavors: with and without redis. However, the original civ1 only run redis tests for a subset of minimal tests: https://github.com/ray-project/ray/blob/master/ci/ci.sh#L669
Fix the behavior of civ2 to align with civ1. This also fixes the flakiness from test_basic_4.py (my guess is the additional tests in civ2, which are not skipped, leaks a state that cause the flakiness here).
Test: