Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Error check Redis get requests #40333

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Conversation

vitsai
Copy link
Contributor

@vitsai vitsai commented Oct 13, 2023

It is possible for a Redis Get to silently fail in the current logic. Fix this to avoid weird downstream effects (such as session key inconsistency)

Why are these changes needed?

Related issue number

#40412

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: vitsai <vitsai@cs.stanford.edu>
Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@vitsai vitsai marked this pull request as ready for review October 13, 2023 22:16
@vitsai vitsai requested a review from a team as a code owner October 13, 2023 22:16
@vitsai vitsai linked an issue Oct 17, 2023 that may be closed by this pull request
@fishbone
Copy link
Contributor

Synced offline. It seems that we have already crashed the program when receiving an error here

So the error might come from Connect here

Some simple test without Redis can verify this.

Signed-off-by: vitsai <vitsai@cs.stanford.edu>
python/ray/_raylet.pyx Outdated Show resolved Hide resolved
Copy link
Contributor

@fishbone fishbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Signed-off-by: vitsai <vitsai@cs.stanford.edu>
@rkooo567 rkooo567 merged commit d28f645 into ray-project:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Silent failure when retrieving session key from Redis
3 participants