-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] New persistence mode cleanup: Tune internals #40175
Merged
justinvyu
merged 16 commits into
ray-project:master
from
justinvyu:cleanup_old_codepath_tune
Oct 6, 2023
Merged
[tune] New persistence mode cleanup: Tune internals #40175
justinvyu
merged 16 commits into
ray-project:master
from
justinvyu:cleanup_old_codepath_tune
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
matthewdeng
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go clean code!
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
…nup_old_codepath_tune
justinvyu
changed the title
[tune] New persistence mode cleanup: Old codepaths in Tune
[tune] New persistence mode cleanup: Tune internals
Oct 6, 2023
8 tasks
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
This PR removes the old persistence codepath from all Tune internals except for Trainable, FunctionTrainable, and Tune session. Those are larger changes that are split into a follow-up. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
This PR removes the old persistence codepath from all Tune internals except for Trainable, FunctionTrainable, and Tune session. Those are larger changes that are split into a follow-up. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the old persistence codepath from all Tune internals except for Trainable, FunctionTrainable, and Tune session. Those are larger changes that are split into a follow-up.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.