Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Separate Windows Serve tests into their own build #40057

Merged
merged 13 commits into from
Oct 5, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Oct 3, 2023

Why are these changes needed?

The windows tests are quite flaky and take a long time to run. When I'm merging Serve PRs, I want to be able to quickly find and evaluate Serve-specific tests on Windows. This will help avoid introducing failures/flakiness.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from can-anyscale October 3, 2023 18:53
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edoakes edoakes merged commit 646cce9 into ray-project:master Oct 5, 2023
Zandew pushed a commit to Zandew/ray that referenced this pull request Oct 10, 2023
…0057)

The windows tests are quite flaky and take a long time to run. When I'm merging Serve PRs, I want to be able to quickly find and evaluate Serve-specific tests on Windows. This will help avoid introducing failures/flakiness.
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…0057)

The windows tests are quite flaky and take a long time to run. When I'm merging Serve PRs, I want to be able to quickly find and evaluate Serve-specific tests on Windows. This will help avoid introducing failures/flakiness.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants