Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for dataclass serialization #3984

Merged
merged 7 commits into from
Feb 13, 2019
Merged

Add regression tests for dataclass serialization #3984

merged 7 commits into from
Feb 13, 2019

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Feb 7, 2019

What do these changes do?

Related issue number

@pcmoritz pcmoritz changed the title Add regression tests for dataclasse serialization Add regression tests for dataclass serialization Feb 7, 2019
robertnishihara
robertnishihara reviewed Feb 8, 2019
View reviewed changes
test/runtest.py Outdated

# Serializing dataclass types

@dataclass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test only makes sense for Python 3.7, right? (which we currently don't include in our CI)

robertnishihara
robertnishihara reviewed Feb 8, 2019
View reviewed changes
test/runtest.py Outdated
@@ -260,6 +260,47 @@ class ClassA(object):
ray.put(obj)


def test_serialize_dataclasses(ray_start):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lump this in with the other serialization tests? Ideally we'd have a single test for serialization and not one ray.init call for every object that we want to test.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11668/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11782/
Test FAILed.

@pcmoritz pcmoritz force-pushed the serialize-dataclasses branch from 6e9e35b to 708eb49 Compare February 12, 2019 02:56
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11810/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11815/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11816/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11837/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11844/
Test FAILed.

@pcmoritz
Copy link
Contributor Author

The python 3.7 test passes locally for me on this branch (it's not tested in travis yet)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11860/
Test FAILed.

@robertnishihara robertnishihara merged commit b3f72e8 into ray-project:master Feb 13, 2019
@robertnishihara robertnishihara deleted the serialize-dataclasses branch February 13, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @AmplabJenkins @robertnishihara