Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] add diagram in overview page #39512

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Sep 9, 2023

Why are these changes needed?

Adds a diagram to the Overview page

image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment with the location of the source file for the diagram.

@matthewdeng matthewdeng merged commit f9b1944 into ray-project:master Sep 9, 2023
matthewdeng added a commit to matthewdeng/ray that referenced this pull request Sep 9, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
GeneDer pushed a commit that referenced this pull request Sep 10, 2023
…39515)

* [docs] update doc links in Use Cases (#39445)

Signed-off-by: Matthew Deng <matt@anyscale.com>

* [train][release] Fix `tune_worker_fault_tolerance` release test node killing (#39233)


Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train] Do not raise warning when no results were reported (#39454)

Signed-off-by: Kai Fricke <kai@anyscale.com>

* [train] add diagram in overview page (#39512)

Signed-off-by: Matthew Deng <matt@anyscale.com>

* [train] New persistence mode: Sanity-check release test (#39354)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Co-authored-by: matthewdeng <matt@anyscale.com>

* [train][doc] Configuring persistent storage user guide (#39428)


Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: matthewdeng <matthew.j.deng@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Co-authored-by: matthewdeng <matt@anyscale.com>

* [train][doc] New checkpointing user guide (#39505)


Signed-off-by: Justin Yu <justinvyu@anyscale.com>

---------

Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: matthewdeng <matthew.j.deng@gmail.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Signed-off-by: Matthew Deng <matt@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants