Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable redis password in Java worker #3943

Merged
merged 5 commits into from
Feb 12, 2019
Merged

Enable redis password in Java worker #3943

merged 5 commits into from
Feb 12, 2019

Conversation

jovany-wang
Copy link
Contributor

This PR enables redis password for Java worker.

@jovany-wang jovany-wang requested a review from raulchen February 4, 2019 12:07
jovany-wang
jovany-wang commented Feb 4, 2019
View reviewed changes
java/runtime/src/main/java/org/ray/runtime/runner/RunManager.java Outdated
private String startRedisInstance(String ip, int port, Integer shard) {
private String startRedisInstance(String ip, int port, String password, Integer shard) {
String passwordCommand = "";
if (!StringUtil.isNullOrEmpty(password)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raulchen I couldn't find some thing like Lists.of() to replace ImmutableLists.of() here.
Could you plz give me some suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Lists.newArrayList

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11530/
Test PASSed.

raulchen
raulchen reviewed Feb 8, 2019
View reviewed changes
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter failed, otherwise looks good

java/runtime/src/main/java/org/ray/runtime/runner/RunManager.java Outdated
private String startRedisInstance(String ip, int port, Integer shard) {
private String startRedisInstance(String ip, int port, String password, Integer shard) {
String passwordCommand = "";
if (!StringUtil.isNullOrEmpty(password)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Lists.newArrayList

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11718/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11720/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11757/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11772/
Test FAILed.

@guoyuhong
Copy link
Contributor

@AmplabJenkins retest this, please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11778/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11781/
Test PASSed.

@guoyuhong guoyuhong merged commit c523bc0 into ray-project:master Feb 12, 2019
@guoyuhong guoyuhong deleted the java-redis-pwd branch February 12, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@guoyuhong guoyuhong guoyuhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jovany-wang @AmplabJenkins @guoyuhong @raulchen