Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] node caching changes #3937

Merged
merged 8 commits into from
Feb 4, 2019
Merged

[autoscaler] node caching changes #3937

merged 8 commits into from
Feb 4, 2019

Conversation

hartikainen
Copy link
Contributor

@hartikainen hartikainen commented Feb 3, 2019 •
edited by richardliaw
Loading

What do these changes do?

Breaks the node provider node getter into cached and non-cached versions.

Related issue number

Closes #3930, Closes #3935

@hartikainen hartikainen changed the title Bug fix/autoscaler node caching [autoscaler] node caching changes Feb 3, 2019
@hartikainen
Copy link
Contributor Author

I don't know if this is a good long term solution, but still fixes the two issues.

hartikainen
hartikainen commented Feb 3, 2019
View reviewed changes
python/ray/autoscaler/gcp/example-full.yaml
@@ -61,7 +61,7 @@ head_node:
initializeParams:
diskSizeGb: 50
# See https://cloud.google.com/compute/docs/images for more images
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this example to fix it and match the aws/example-full.yaml

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11468/
Test FAILed.

ericl
ericl approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache handling looks good. Are the fingerprint fixes also here?

python/ray/autoscaler/aws/node_provider.py
node = self._get_cached_node(node_id)

if node.public_ip_address is None:
node = self._get_node(node_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ericl
Copy link
Contributor

ericl commented Feb 3, 2019

Oh I see the change now.

@hartikainen hartikainen mentioned this pull request Feb 3, 2019
Closed
7 tasks
@ericl @hartikainen
Apply suggestions from code review
e559c0b 
Co-Authored-By: hartikainen <kristian.hartikainen@gmail.com>
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11480/
Test PASSed.

@ericl
Copy link
Contributor

ericl commented Feb 3, 2019

Some lint errors

@hartikainen
Copy link
Contributor Author

Should be fixed now.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11484/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11488/
Test PASSed.

@richardliaw richardliaw merged commit 85294fb into ray-project:master Feb 4, 2019
@ls-daniel
Copy link
Contributor

All looks good to me. Apologies; I didn't have an easy way to test on GCP.

@hartikainen hartikainen deleted the bug-fix/autoscaler-node-caching branch February 5, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hartikainen @AmplabJenkins @ericl @ls-daniel @richardliaw