Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data][tests] Update image processing benchmarks to use ImageNet #39207

Merged
merged 16 commits into from
Sep 5, 2023

Conversation

stephanie-wang
Copy link
Contributor

@stephanie-wang stephanie-wang commented Sep 1, 2023

Why are these changes needed?

Updates to some image processing nightly benchmarks:

  • Use ImageNet dataset - unlike the current test dataset, has images of all different sizes, some in grayscale (instead of RGB), and on average smaller
  • Consolidate "preprocessed_image_loader" and "image_loader" microbenchmarks
  • Add microbenchmark for reading from parquet files
  • Add S3 Dataset for MosaicML streaming

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Attention: External code changed

A previous version of this PR changed code that is used or cited in external sources, e.g. blog posts.

It looks like these changes have been reverted or are otherwise not present in this PR anymore. Please still carefully review the changes to make sure code we use in external sources still works.

Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
@stephanie-wang stephanie-wang merged commit bb23051 into ray-project:master Sep 5, 2023
@stephanie-wang stephanie-wang deleted the mlperf-blog branch September 5, 2023 23:17
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…-project#39207)

Updates to some image processing nightly benchmarks:

    Use ImageNet dataset - unlike the current test dataset, has images of all different sizes, some in grayscale (instead of RGB), and on average smaller
    Consolidate "preprocessed_image_loader" and "image_loader" microbenchmarks
    Add microbenchmark for reading from parquet files
    Add S3 Dataset for MosaicML streaming
---------

Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…-project#39207)

Updates to some image processing nightly benchmarks:

    Use ImageNet dataset - unlike the current test dataset, has images of all different sizes, some in grayscale (instead of RGB), and on average smaller
    Consolidate "preprocessed_image_loader" and "image_loader" microbenchmarks
    Add microbenchmark for reading from parquet files
    Add S3 Dataset for MosaicML streaming
---------

Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants