[train] Disallow trainer_resources() in ScalingConfig for GBDT trainers #39059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 2 commits
August 29, 2023 15:59
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
krfricke
added
the
tests-ok
matthewdeng
reviewed
Aug 31, 2023
added 3 commits
September 1, 2023 17:36
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
Yard1,
maxpumperla and
a team
as code owners
matthewdeng
reviewed
Sep 1, 2023
added 2 commits
September 5, 2023 09:55
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
matthewdeng
approved these changes
Sep 5, 2023
added 2 commits
September 6, 2023 14:40
Signed-off-by: Kai Fricke <kai@anyscale.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…rs (ray-project#39059) `ScalingConfig.trainer_resources` are currently silently dropped in GBDT trainers. Instead, we should raise an error when this is set. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…rs (ray-project#39059) `ScalingConfig.trainer_resources` are currently silently dropped in GBDT trainers. Instead, we should raise an error when this is set. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ScalingConfig.trainer_resourcesare currently silently dropped in GBDT trainers. Instead, we should raise an error when this is set.Related issue number
Closes #39058
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.