Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Added possibility to execute infinite recovery retries for a trial #3901

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

SieversLeon
Copy link
Contributor

Allows to let a trial try to do infinite recoveries by setting max_failures to a negative number. Is certainly nicer than just randomly picking a high number for max_failures.

@SieversLeon SieversLeon changed the title Added possibility to execute infinite recovery retries for a trial [tune] Added possibility to execute infinite recovery retries for a trial Jan 30, 2019
@richardliaw
Copy link
Contributor

Does float(“inf”) work here on current master?

@SieversLeon
Copy link
Contributor Author

Does float(“inf”) work here on current master?

Good call, would probably work, but I think it is a bit odd to pass a float for an int argument.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11299/
Test PASSed.

@richardliaw
Copy link
Contributor

This looks good - can you fix the linting issues on Travis?

@richardliaw richardliaw self-assigned this Jan 30, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11316/
Test PASSed.

@richardliaw richardliaw merged commit d3551dd into ray-project:master Jan 31, 2019
@richardliaw
Copy link
Contributor

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants