Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] Fix wandb/comet integration API calls #38978

Merged
merged 6 commits into from
Aug 31, 2023
Merged

[train] Fix wandb/comet integration API calls #38978

merged 6 commits into from
Aug 31, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Aug 28, 2023 •
edited
Loading

Why are these changes needed?

Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Related issue number

Closes #38960

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

[train] Fix integration API calls
222c653 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke marked this pull request as ready for review August 28, 2023 12:41
@krfricke krfricke requested a review from justinvyu August 28, 2023 12:41
@krfricke krfricke added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. Ray-2.7 labels Aug 28, 2023
justinvyu
justinvyu reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me! Had one nit to avoid needing to update the ray.train._checkpoint import.

storage context flag
04c9267 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke requested a review from justinvyu August 29, 2023 08:21
@krfricke krfricke changed the title [train] Fix integration API calls [train] Fix wandb/comet integration API calls Aug 29, 2023
justinvyu
justinvyu reviewed Aug 29, 2023
View reviewed changes
Kai Fricke added 2 commits August 29, 2023 20:57
@krfricke krfricke requested a review from justinvyu August 29, 2023 21:21
justinvyu
justinvyu reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after this fix:

Kai Fricke added 2 commits August 31, 2023 13:34
justinvyu
justinvyu approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit b248d36 into ray-project:master Aug 31, 2023
@krfricke krfricke deleted the dir-or-data branch August 31, 2023 17:44
matthewdeng pushed a commit to matthewdeng/ray that referenced this pull request Sep 1, 2023
@krfricke @matthewdeng
[train] Fix wandb/comet integration API calls (ray-project#38978)
341f226 
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>
GeneDer pushed a commit that referenced this pull request Sep 1, 2023
@matthewdeng @woshiyyya
@justinvyu @krfricke @amogkam @angelinalg
[train][2.7][2/n] cherry-picks for documentations, tests, examples (#…
71c4117 
…39195)

* [CI] Remove tags for AIR and AIR smoke test (#39075)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [train] New persistence mode: Finish migrating `Tune tests + examples (small)` (#39047)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train] Rename `train(config)` to `train_fn(config)` (#39065)

Our API change from `tune.report()` to `train.report()` can lead to namespace clashes when the training function is called `train`.

This has been an issue in many test migrations, including #39050 and the current failure of #38493.

This PR does a global replace of all training function defined as `def train(config)` with `def train_fn(config)` to avoid future clashes.

Signed-off-by: Kai Fricke <kai@anyscale.com>

* [Data/Train] [Docs] Re-organize data loading performance tips (#39096)

Re-organize data loading performance tips. We want the caching and the CPU nodes sections to be together since they are both addressing the same problems of optimizing performance when you have expensive CPU preprocessing, and the latter references the former.

Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>

* [air] Hard deprecate PredictorDeployment and PredictorWrapper (#39108)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* Update the DeepSpeed and Accelerate doc example with new Checkpoint API. (#39014)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>

* [train] New persistence mode: Remove some legacy `air.Checkpoint` dependencies (#39049)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train] Fix wandb/comet integration API calls (#38978)

Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>

* [tune] Deprecate `tune.report`, `tune.checkpoint_dir`, `checkpoint_dir`, and `reporter` (#39093)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [2.7][Example] Enable new APIs for Lightning `dolly-v2-7b` Fine-tuning Example (#39117)

Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

* [train] New persistence mode: Re-enable py37 compatibility tests (#39121)


Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [Ray 2.7 Examples][1/n] Revamp the LightningTrainer CoLA Example (#38009)

Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

* [train] New persistence mode: Support `chdir_to_trial_dir` functionality with `RAY_CHDIR_TO_TRIAL_DIR` env var (#39107)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train] New persistence mode: Minimal `BackendExecutor` cleanup (#39187)

Signed-off-by: Justin Yu <justinvyu@anyscale.com>

* [train/rllib] RLlib GPU storage context tests (#39166)

Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

* [docs][train] Update Train landing and Overview pages (#38808)

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>

---------

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Signed-off-by: Yunxuan Xiao <xiaoyunxuan1998@gmail.com>
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Yunxuan Xiao <yunxuanx@anyscale.com>
Co-authored-by: Justin Yu <justinvyu@anyscale.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@krfricke @LeonLuttenberger
[train] Fix wandb/comet integration API calls (ray-project#38978)
8215d0b 
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@krfricke @jimthompson5802
[train] Fix wandb/comet integration API calls (ray-project#38978)
8f3f145 
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@krfricke
[train] Fix wandb/comet integration API calls (ray-project#38978)
efbdca0 
Removes remaining calls to checkpoint.dir_or_data in the wandb/comet integrations

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvyu justinvyu justinvyu approved these changes

Assignees

@justinvyu justinvyu

Labels
Ray-2.7 tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[train][GA] Remove remaining checkpoint.dir_or_data usage
3 participants
@krfricke @justinvyu @matthewdeng