Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[train] Storage: XGBoost+LightGBM release tests #38886

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[train] Storage: XGBoost+LightGBM release tests #38886

merged 1 commit into from
Aug 25, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

[train] Storage: XGBoost+LightGBM release tests
b8bcb12 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. Ray-2.7 labels Aug 25, 2023
zhe-thoughts
zhe-thoughts approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, test-only change

@zhe-thoughts zhe-thoughts merged commit 9b8e903 into ray-project:master Aug 25, 2023
@krfricke krfricke deleted the train/xgboost-lightgbm-release-tests branch August 25, 2023 17:16
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@krfricke @arvind-chandra
[train] Storage: XGBoost+LightGBM release tests (ray-project#38886)
b15758d 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger pushed a commit to jaidisido/ray that referenced this pull request Sep 5, 2023
@krfricke @LeonLuttenberger
[train] Storage: XGBoost+LightGBM release tests (ray-project#38886)
c861624 
Signed-off-by: Kai Fricke <kai@anyscale.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
@krfricke @jimthompson5802
[train] Storage: XGBoost+LightGBM release tests (ray-project#38886)
8805c4d 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@krfricke
[train] Storage: XGBoost+LightGBM release tests (ray-project#38886)
b4c023a 
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@justinvyu justinvyu Awaiting requested review from justinvyu

Assignees

@justinvyu justinvyu

@matthewdeng matthewdeng

@zhe-thoughts zhe-thoughts

Labels
Ray-2.7 tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krfricke @matthewdeng @zhe-thoughts @justinvyu